Fix warnings #2881
Merged
Fix warnings #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2017 11:38
Codecov Report@@ Coverage Diff @@
## master #2881 +/- ##
==========================================
+ Coverage 27.8% 27.82% +0.01%
==========================================
Files 20 20
Lines 3625 3626 +1
Branches 656 656
==========================================
+ Hits 1008 1009 +1
Misses 2441 2441
Partials 176 176
Continue to review full report at Codecov.
|
igrr
requested changes
Jan 19, 2017
There was a problem hiding this comment.
Thanks for cleaning up the warnings!
I wonder if we can tweak build flags when doing Travis build to error out on warnings in the first place...
Just a few notes about struct initializers — i think memset will be a better option, as the current way doesn't look very maintainable :)
| @@ -49,7 +49,7 @@ class SPIFFSImpl : public FSImpl | |||
| { | |||
| public: | |||
| SPIFFSImpl(uint32_t start, uint32_t size, uint32_t pageSize, uint32_t blockSize, uint32_t maxOpenFds) | |||
| : _fs({0}) | |||
| : _fs{{0, 0, 0, 0, 0, 0, 0, 0}, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} | |||
There was a problem hiding this comment.
How about we remove this initializer and use memset instead?
| @@ -176,7 +176,7 @@ class SPIFFSImpl : public FSImpl | |||
|
|
|||
| bool _tryMount() | |||
| { | |||
| spiffs_config config = {0}; | |||
| spiffs_config config = {0, 0, 0, 0, 0, 0, 0, 0}; | |||
There was a problem hiding this comment.
same here — memset will look slightly cleaner
| @@ -268,7 +273,7 @@ class SPIFFSFileImpl : public FileImpl | |||
| SPIFFSFileImpl(SPIFFSImpl* fs, spiffs_file fd) | |||
| : _fs(fs) | |||
| , _fd(fd) | |||
| , _stat({0}) | |||
| , _stat{0, 0, 0, 0, {0}} | |||
| @@ -376,7 +381,7 @@ class SPIFFSFileImpl : public FileImpl | |||
| auto rc = SPIFFS_fstat(_fs->getFs(), _fd, &_stat); | |||
| if (rc != SPIFFS_OK) { | |||
| DEBUGV("SPIFFS_fstat rc=%d\r\n", rc); | |||
| _stat = {0}; | |||
| _stat = {0, 0, 0, 0, {0}}; | |||
Lauszus
added a commit
to felis/USB_Host_Shield_2.0
that referenced
this pull request
Feb 1, 2017
This should be removed when the ESP8266 core is updated in PlatformIO: esp8266/Arduino#2881
Lauszus
added a commit
to felis/USB_Host_Shield_2.0
that referenced
this pull request
Feb 1, 2017
This should be removed when the ESP8266 core is updated in PlatformIO: esp8266/Arduino#2881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I fixed some warnings related to unused variables and uninitialized fields. I think not everyone is Core developer, so users should not see warnings in Core code when they compile their sketches. Related issue: #2587.